-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build error #2644
base: master
Are you sure you want to change the base?
fix build error #2644
Conversation
[Experimental Bot, please feedback here] NuttX PR Requirements ReviewMeets Requirements? Partially Summary: While the PR addresses a real issue (#2632), the summary section lacks crucial details:
Impact:
Testing:
Recommendation: Expand the Summary and Impact sections with the missing information. Provide detailed testing logs to showcase the change's effectiveness. |
examples/nettest/nettest_server.c
Outdated
#ifdef __APPLE__ | ||
acceptsd = accept(listensd, (struct sockaddr *)&myaddr, &addrlen); | ||
#else | ||
#if !defined(__APPLE__) && defined(__NuttX__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#if !defined(__APPLE__) && defined(__NuttX__) | |
#ifdef __NuttX__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
#ifdef __APPLE__ | ||
acceptsd = accept(listensd, (FAR struct sockaddr *)&myaddr, &addrlen); | ||
#else | ||
#if !defined(__APPLE__) && defined(__NuttX__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#if !defined(__APPLE__) && defined(__NuttX__) | |
#ifdef __NuttX__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
[linguini@pastabox nuttx]$ make -j CC: tcpblaster_server.c LN: platform/board to /home/linguini/cuinspace/pico-nuttx/apps/platform/dummy tcpblaster_server.c: In function ‘tcpblaster_server’: tcpblaster_server.c:159:14: error: implicit declaration of function ‘accept4’; did you mean ‘accept’? [-Wimplicit-function-declaration] 159 | acceptsd = accept4(listensd, (FAR struct sockaddr *)&myaddr, &addrlen, | ^~~~~~~ | accept make[3]: *** [Makefile:92: tcpblaster_server.hobj] Error 1 make[2]: *** [Makefile:53: /home/linguini/cuinspace/pico-nuttx/apps/examples/tcpblaster_context] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Makefile:180: context] Error 2 make: *** [tools/Unix.mk:457: /home/linguini/cuinspace/pico-nuttx/apps/.context] Error 2 make: *** Waiting for unfinished jobs.... from apache#2632 Signed-off-by: wanggang26 <[email protected]>
Summary
[linguini@pastabox nuttx]$ make -j
CC: tcpblaster_server.c
LN: platform/board to
/home/linguini/cuinspace/pico-nuttx/apps/platform/dummy tcpblaster_server.c: In function ‘tcpblaster_server’: tcpblaster_server.c:159:14: error: implicit declaration of function ‘accept4’; did you mean ‘accept’? [-Wimplicit-function-declaration]
159 | acceptsd = accept4(listensd, (FAR struct sockaddr *)&myaddr,
&addrlen,
| ^~~~~~~
| accept
make[3]: *** [Makefile:92: tcpblaster_server.hobj] Error 1
make[2]: *** [Makefile:53:
/home/linguini/cuinspace/pico-nuttx/apps/examples/tcpblaster_context]
Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:180: context] Error 2
make: *** [tools/Unix.mk:457:
/home/linguini/cuinspace/pico-nuttx/apps/.context] Error 2
make: *** Waiting for unfinished jobs....
Impact
from #2632
Testing
CI TEST